Repository navigation
[access] refactor(objects): the renderer takes three service bundles and its property guard - #7507
Conversation
…roperty guard RenderObject::__construct took 23 parameters. It now takes the stores it reads (mappers, files), the enrichers it adds (translations, derived values), the runtime it works in (logger, request, lazy container and the optional read extensions) and the property RBAC handler, which stays a direct parameter as an access guard. Every bundle is autowired; the nullable extensions keep their null defaults. Assisted-by: ClaudeCode
…r now holds Assisted-by: ClaudeCode
Assisted-by: ClaudeCode
|
Newman API Test Suite is red, and the failure is not this PR's. The job runs the full unit suite: 11 errors and 11 failures. They are in The same Generated by Claude Code |
|
This PR changes no file under Generated by Claude Code |
|
Generated by Claude Code |
|
The fixes belong on Generated by Claude Code |
|
Psalm reports 60 errors across 35 files, for example Generated by Claude Code |
|
PHPStan finds 24 errors. All of them are in files this PR does not change: Generated by Claude Code |
|
Generated by Claude Code |
|
The run reports 459 findings, almost all inherited from Generated by Claude Code |
|
This is the live-instance check that would catch a wiring fault in the new render bundles ( The one failure visible in the part of the log the API returns is in a flow, not in rendering: Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 12:16 UTC
Download the full PDF report from the workflow artifacts.
Lane K16, round 10c — SIG unit interfacing.
What changed
RenderObject::__constructtook 23 parameters. It now takes four:RenderStores(RenderMappers: object/register/schema stores and the object cache;RenderFileSources: file mapper, file reader, system tag manager and mapper)RenderEnrichers(RenderTranslations: translation handler, status, mapper, language service;RenderDerivations: computed fields, calculation evaluator, linked-entity enricher, URN service)RenderRuntime(logger,RenderReadExtensions(object-source registry, field encryption, lens resolver — still nullable with null defaults), request, lazy container)PropertyRbacHandler— the access guard stays a direct constructor parameter.finalclass of at most 4 promoted readonly properties, autowired by the container exactly like the controller*Servicesbundles.RenderObjectInterface→RenderObjectbinding is unchanged; no DI semantics change, no logic change — field reads only become$this->stores->mappers->schemaMapperand so on.ExcessiveParameterListsuppression on the constructor is gone, since the warning is.RenderObject(21 constructions in 15 files, plus 5 tests that inject private properties into a bare instance) follows the new shape.What ran (on the branch merged with current
development)tests/Unit/Service/Object/— 4243 tests OK (1 skipped, pre-existing)tests/Unit/Architecture,tests/Unit/Contract,tests/Unit/Kernel,tests/Unit/Service/Rules,ControllerServicesWiringTest,ControllerSessionWiringTest— 2658 tests OKObjectsControllerWriteOnlyListLeakTest,FileRestrictionRenderAndLinkTest,ExplicitRevealRoutesTest,LinkExposureWiringTest,SourceLanguageResolutionTableTest— OKphp -l,phpcs(0 errors; the one warning is the pre-existing missing class@spec),phpstanon touched files — OKNumbers
RenderObject::__construct(23 params, 26 NLOC) leaves the > 4 and > 6 parameter bands: −26 LOC on each for the lane.Written by an AI agent (Claude Code), reviewed by its own guards only.
Generated by Claude Code